Skip to content

PR_26180_OWNER_004-shared-validation-guard-fix#282

Merged
ToolboxAid merged 1 commit into
mainfrom
PR_26180_OWNER_004-shared-validation-guard-fix
Jun 28, 2026
Merged

PR_26180_OWNER_004-shared-validation-guard-fix#282
ToolboxAid merged 1 commit into
mainfrom
PR_26180_OWNER_004-shared-validation-guard-fix

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Fix the Messages shared extraction guard regression by using isFiniteNumber(...) instead of direct Number.isFinite(...) in toolbox/messages/messages.js.
  • Preserve existing typewriter-speed conversion, fallback, and validation behavior.
  • No Sprite Editor, DB/API/schema, or runtime behavior changes intended.

Validation

  • PASS: node --check toolbox/messages/messages.js
  • PASS: node dev/tools/toolbox-dev/checkSharedExtractionGuard.mjs
  • PASS: git diff --check
  • FAIL: npm test passes the shared extraction guard, then fails on unrelated missing module src/engine/combat/Combat.js imported by dev/tests/combat/Combat.test.mjs.

Artifact

  • dev/workspace/zips/PR_26180_OWNER_004-shared-validation-guard-fix_delta.zip

Merge / Baseline

  • Not merged because the requested npm test PASS condition was not met.
  • Baseline commit was not created.

@ToolboxAid ToolboxAid marked this pull request as ready for review June 28, 2026 20:39
@ToolboxAid ToolboxAid merged commit c93d674 into main Jun 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant